Comments on: Django SocialAuth component, now with some Elfin goodness…

By: Scot Hacker

Scot Hacker — Thu, 11 Feb 2010 08:01:42 +0000

Docs say I need in settings:
FACEBOOK_API_SECRET=

but upon first FB connection, Django complains that I need:
FACEBOOK_SECRET_KEY

I assume this is the same, and is a typo in the docs. Set FACEBOOK_SECRET_KEY be the same as API_SECRET, but now clicking the FB Connect button does nothing.

By: Scot Hacker

Scot Hacker — Thu, 11 Feb 2010 07:51:56 +0000

In template socialauth/login.html there are two javascript lines in block extra_body. Shouldn’t these be in block extra_head (since javascript goes in the head?)

By: Scot Hacker

Scot Hacker — Thu, 11 Feb 2010 07:48:29 +0000

Just digging in with this – project sounds promising. Couldn’t see a way to file bugs at github so leaving notes here.

There are two templates: socialauth_base.html and socialauth/socialauth_base.html . They are not duplicates. Is this redundancy intentional?

By: Panos Laganakos

Panos Laganakos — Fri, 11 Dec 2009 21:21:38 +0000

I agree with most of the stuff here, and gave a look at your commits on github.

Why do you worry about an app’s base.html overlapping any other? We already extend an app specific template by:

{% extends ‘app_name/base.html’ %}

while

{% extends ‘app_name/app_name_base.html’ %}

looks a bit over-explicit.

“Explicit is better than implicit” – I agree, but I think this is kinda too much

Other than that, good work – the middleware sounds like a nice idea.